-
Notifications
You must be signed in to change notification settings - Fork 83
Update the examples of display store information #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR includes documentation updates Updated pages: |
| Store format introduced in: 5.0.0 | ||
| Database name: healthcare | ||
| Database in use: false | ||
| Store format version: block-block-1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we provide example with the block format, should we label it 'Enterprise edition'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to label the example output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about labelling the whole example.
Now I think this would look weird.
I'm wondering if we need to clarify that we test Enterprise edition here. For example,
[source, shell]
----
bin/neo4j-admin database info healthcare
----
+
If you're using Neo4j Enterprise Edition, the output can be the following:
+
[results]
----
Database name: healthcare
Database in use: false
Store format version: block-block-1.1
<....>
----
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or it is unnecessary and we don't have to go into much detail here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add a sentence before all examples to say, "The following examples assume that you are using Neo4j Enterprise edition."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NataliaIvakina, I added two intro sentences. Could you please take a look if they make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌 Looks great!
NataliaIvakina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I suppose you have tested everything 😄
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
No description provided.